Fix timings table footer column count when custom timings exist#697
Open
leno23 wants to merge 1 commit into
Open
Fix timings table footer column count when custom timings exist#697leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
The timings table header adds dynamic columns for CustomTimingStats, but the footer row always spanned only five columns. Browsers then warn that the footer row is narrower than the header row. Add matching empty footer cells for each custom timing column. Fixes MiniProfiler#687 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CustomTimingStats(for example SQL timings).Fixes #687
Test plan
MiniProfiler.Shared(TypeScript compile + bundle)